Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: blockquote code continuation #3264

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 20, 2024

Marked version: 12.0.2

Description

Fix blockquote continuation for code blocks

Fixes CommonMark #236
Fixes CommonMark #237

also adds space token after blockquote and hr if there are multiple newlines. fixes #3167.

I believe this will be a breaking change since tokens will change even though the output won't change.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 3:42pm

@UziTech UziTech changed the title test blockquote fix: fix blockquote code continuation and add space token after Apr 21, 2024
@UziTech UziTech marked this pull request as ready for review April 22, 2024 04:26
@UziTech UziTech requested a review from calculuschild April 22, 2024 04:32
@UziTech UziTech changed the title fix: fix blockquote code continuation and add space token after BREAKING CHANGE: fix blockquote code continuation and add space token after Apr 22, 2024
@UziTech UziTech requested review from styfle, joshbruce, davisjam and calculuschild and removed request for calculuschild April 22, 2024 04:32
src/Tokenizer.ts Outdated Show resolved Hide resolved
src/Tokenizer.ts Outdated Show resolved Hide resolved
@UziTech UziTech changed the title BREAKING CHANGE: fix blockquote code continuation and add space token after fix: blockquote code continuation Jun 12, 2024
@UziTech UziTech merged commit 7ab8185 into markedjs:master Jun 12, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
# [13.0.0](v12.0.2...v13.0.0) (2024-06-12)

### Bug Fixes

* blockquote code continuation ([#3264](#3264)) ([7ab8185](7ab8185))

### Features

* Send token objects to renderers ([#3291](#3291)) ([1ce59ea](1ce59ea))

### BREAKING CHANGES

* extensions that change marked renderers will need to be updated and use new option `useNewRenderer`
* add space token after blockquote and hr if there are multiple newlines
@UziTech UziTech deleted the blockquote-test branch June 25, 2024 04:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lexer handling newlines incorrectly in some cases
2 participants