Add explicit ids for headers #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if this PR takes this situation #664 into account or falls prey to the same inconsistent casing problem. |
|
Please describe what this PR is for. |
| Lexer.prototype.id_generator = function(title, explicit_id) { | ||
| var draft = explicit_id ? explicit_id : title; | ||
| draft = this.options.headerPrefix + draft; | ||
| return draft.toLowerCase().replace(/[^\w]+/g, '-'); |
There was a problem hiding this comment.
Explicit ID should be returned as is, without being case-converted or transformed in any way. If author supplied explicit IDs, there must be a good reason why he did so. Hence it should be used as is. No point in transforming it any further.
|
Believe this is already taken care of. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.