feat: Created a express based server with --server #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a express server activated with the
--serverCLI parameter:This opens a server at default
localhost:8080with aPOST /renderroute. This route accepts a MJML body or a JSON with the following structure:{ "mjml": "<mjml></mjml>" }The response contains the rendered HTML and optionally an error array:
{ "result": { "errors": [], "html": "<!doctype html>\n <html xmlns[...]" } }To change default
localhost:8080you can use the--portand--hostparameters:The reason for this change is that I'm testing a new method to call the MJML parsed based on HTTP requests instead of calling the
nodebinary in order to avoid slow cool starts.