Update GraphQLService.php #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue markhuot#342
|
Interesting, any idea where the |
|
I think PHP 8 being more strict it doesn’t accept null as false. In dev
mode it will doesn’t fail because it accepts true (even when it basically
want an int).
|
|
I think it doesn’t even give true in dev mode, but some int value actually.
|
|
When will this be merged? This bug is blocking our development right now... |
|
Pulled changes locally can confirm this is the perfect solution! |
|
@markhuot thank you for merging. It would be great if this MR could be released in a stable version asap. Thanks 😊 |
|
This is now included in https://github.com/markhuot/craftql/releases/tag/1.3.7 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #342