[RFR] Fix disabling views #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floo51
force-pushed
the
fix_disabling_views
branch
from
e007fa9
to
453cb69
Compare
Kmaschta
approved these changes
Apr 5, 2017
|
Mergeable - @Kmaschta |
Kmaschta
reviewed
Apr 5, 2017
| @@ -84,8 +84,7 @@ | |||
| .baseApiUrl('http://localhost:3000/') // The base API endpoint can be customized by entity | |||
| .identifier(nga.field('id')); // you can optionally customize the identifier used in the api ('id' by default) | |||
|
|
|||
| var tag = nga.entity('tags') | |||
| .readOnly(); // a readOnly entity has disabled creation, edition, and deletion views | |||
There was a problem hiding this comment.
What are the effects of your admin-config update on readOnly feature?
There was a problem hiding this comment.
The effect is that it now works
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix the disabling of views which wasn't working when you had fields initialized inside the view.
It also fix the test fixtures which were making tags a read only entity and trying to go to its edit page anyway.