Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added missing EditView.getUrl parameter #990

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Conversation

SebLours
Copy link
Contributor

Patch for #871 (EditView, not ListView)

@fzaninotto
Copy link
Member

Could you remove the built files from your PR? They make it hard to merge. I'll rebuild the files myself once merged.

@SebLours
Copy link
Contributor Author

⏪ It's done

@SebLours
Copy link
Contributor Author

I ask my self if this PR is ready ...

For example a route like this (entity with a composite keys id): /#/crew_members/edit/2501,1947
The id will be passed as string ('2501,1947') at EditView.getUrl, i think that in this case, the id argument must be an array [2501,1947]

I don't know how to get the id as array from $state.params ...

@fzaninotto fzaninotto merged commit 97c64ce into marmelab:master Mar 31, 2016
@fzaninotto
Copy link
Member

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants