Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make the basic flag use npm #10497

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Make the basic flag use npm #10497

merged 3 commits into from
Feb 6, 2025

Conversation

erwanMarmelab
Copy link
Contributor

Problem

We want that the basic flag of the create-react-admin downloads the node_modules with npm

How To Test

Capture d’écran du 2025-02-06 11-31-22

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • [ ] The PR includes unit tests (if not possible, describe why)
  • [ ] The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Feb 6, 2025
@fzaninotto fzaninotto merged commit 4299d86 into next Feb 6, 2025
16 checks passed
@fzaninotto fzaninotto deleted the make_the_basic_flag_use_npm branch February 6, 2025 12:40
@fzaninotto fzaninotto added this to the 5.5.4 milestone Feb 6, 2025
@djhi djhi modified the milestones: 5.5.4, 5.6.0 Feb 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@erwanMarmelab @fzaninotto @djhi