-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[chore] Improve release tooling #10516
base: master
Are you sure you want to change the base?
Conversation
step "manual tests: Run the EE tests" | ||
echo "Copy the the packages folder content inside the node_modules of ra-enterprise, then run a full build and run the tests" | ||
echo "Tip: You can use the 'copy-ra-oss-packages-to-ee.sh' script if you have it" | ||
echo "Press Enter when this is done" | ||
read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should agree on a directory structure and do this automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool!
'[demo]', | ||
'[website]', | ||
'[storybook]', | ||
'[demo]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo is there twice
Problem
A large part of the react-admin release process is manual, thus cumbersome and prone to errors.
Solution
Further automate the release process.
Out of scope
Some release steps are not automated yet (due to time constraints).
Examples:
How To Test
Unfortunately it's very cumbersome to test the whole process end-to-end.
Thus, I recommend testing it unitarily instead.
These scripts support a
RELEASE_DRY_RUN
env variable allowing to skip all mutations to git, GitHub or npm.First, create a
.env
file from the.env.template
file and fill it in with your Github token.Then:
To test the pre-release steps:
RELEASE_DRY_RUN=true make release
To test the pre-publish steps:
cd packages/react-admin && RELEASE_DRY_RUN=true yarn run prepublishOnly
To test the post-publish steps:
cd packages/react-admin && RELEASE_DRY_RUN=true yarn run postpublish
Additional Checks
master
for a bugfix, ornext
for a feature