Fix pagination on bulk delete #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMattiussi
added
RFR
fzaninotto
requested changes
Jun 5, 2020
JulienMattiussi
force-pushed
the
fix-pagination-on-delete
branch
from
651ac52 to
d87c8c8
Compare
|
Hi! You have a merge conflict. Could you rebase it? |
fzaninotto
reviewed
Jul 7, 2020
…ead of 0 when parsing "0"
…erying a page out of bounds
Luwangel
force-pushed
the
fix-pagination-on-delete
branch
from
d87c8c8 to
956f627
Compare
JulienMattiussi
commented
Jul 24, 2020
packages/ra-core/src/controller/field/useReferenceArrayFieldController.ts
Outdated
Show resolved
Hide resolved
packages/ra-core/src/controller/field/useReferenceManyFieldController.ts
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4794
Issue 1 :
Fix MUI warning when deleting last items of last page by skipping the rendering before fallback to the previous page.
Issue 2 :
Avoid List to always fallback on Page 1 when bulk-deleting some items.