Fix : Resource name case in confirm for multi-language #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Jun 19, 2020
|
Nice. It's a new feature though and should probably be merged on |
JulienMattiussi
changed the title
JulienMattiussi
changed the title
fzaninotto
requested changes
Jun 19, 2020
examples/demo/src/i18n/en.ts
Outdated
| @@ -40,6 +40,7 @@ const customEnglishMessages: TranslationMessages = { | |||
| resources: { | |||
| customers: { | |||
| name: 'Customer |||| Customers', | |||
| forcedCaseName: 'Customer |||| Customers', | |||
There was a problem hiding this comment.
I don't understand why you add these translations, they should not be necessary.
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
fzaninotto
approved these changes
Jun 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4783
Issue
Resources names are always set to lower case in confirm messages and it doesn't match with all language synxates (ie : in German, names should be capitalized)
Solution
Allow to force case in translation file
Documentation