Update "Not Using the <Admin> Components" doc #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jul 27, 2020
docs/CustomApp.md
Outdated
| + }, | ||
| + () => ({ authProvider }) | ||
| +)(App); | ||
| ``` | ||
|
|
||
| Note that this example still uses `<Resource>`, because this component lazily initializes the store for the resource data. | ||
|
|
||
| Currently the `<Notification>` component is required (See [issue #5026](https://github.com/marmelab/react-admin/issues/5026)). |
There was a problem hiding this comment.
The notification component will always be required for optimistic support so I think you can remove this line
There was a problem hiding this comment.
Done !
Have to say I find it strange that a component called Notification is required for optimistic update. If it can't be changed, maybe it should be renamed ?
fzaninotto
approved these changes
Aug 9, 2020
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update the documentation for "Not Using the
<Admin>Components" to fix several problems.authProviderdoes not work (const authProvider = () => Promise.resolve();), becauseauthProvideris now supposed to be an object instead of a function.localevariable is defined.themeis provided to the<ThemeProvider>.PropTypesdoes not exist so it must be imported from theprop-typespackage.withContextexpectsauthProviderto be aPropTypes.objectinstead of aPropTypes.funcNotificationcomponent is not included, while it is necessary for the data provider to work.The last problem is probably a bug but I think it can be worth documenting it until the bug is fixed.