-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
List - Optional Sync With Location #5741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add unit tests?
), | ||
})}`, | ||
}); | ||
} | ||
dispatch(changeListParams(resource, newParams)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should keep on relying on the Redux state when we don't sync with location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Make the synchronization with the current location (URL) optional.
By default, this is enabled when a list is passed to a
<Resource>
. Otherwise the synchronization is opt-in using thesyncWithLocation
prop