Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Warning About Unsaved Change #5776

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 14, 2021

Fixes #4969, #5267 and #4969

@djhi djhi added the RFR Ready For Review label Jan 14, 2021
@djhi djhi added this to the 3.11.3 milestone Jan 14, 2021
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though bug, kudos for finding a fix!

Id really like a unit test to secure the bug in the future, though. As it seems caused by a final-form shortcoming, we must detect if they ever trigger it again.

@fzaninotto fzaninotto merged commit 560da38 into master Jan 15, 2021
@fzaninotto fzaninotto deleted the fix-unsaved-changes-warning branch January 15, 2021 17:01
@WiXSL WiXSL changed the title Fix Warning Avout Unsaved Change Fix Warning About Unsaved Change Dec 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning for unsaved changes when updating a <CheckboxGroupInput>
2 participants