Add ListContext to ReferenceArrayInput #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Feb 8, 2021
•
djhi
commented
- Implementation
- Ability to select rows to change the input value
- Tests
- Documentation
djhi
force-pushed
the
reference-array-input-list-context
branch
from
44406e2 to
7eeb242
Compare
fzaninotto
approved these changes
Feb 19, 2021
|
This should be PRed against |
djhi
force-pushed
the
reference-array-input-list-context
branch
from
d5aace6 to
8382e14
Compare
fzaninotto
requested changes
Feb 22, 2021
| const context = useContext(ReferenceArrayInputContext); | ||
|
|
||
| if (props.choices) { | ||
| return props; |
There was a problem hiding this comment.
Please use a more fine-grained approach, as in useListContext in master
| @@ -0,0 +1,9 @@ | |||
| import { Record, RecordMap } from '../types'; | |||
|
|
|||
| export const indexById = (records: Record[] = []): RecordMap => | |||
There was a problem hiding this comment.
please add jsDoc with sample input/output
| const listContext = useMemo( | ||
| () => ({ | ||
| ...controllerProps, | ||
| setSort: controllerProps.setSortForList, |
There was a problem hiding this comment.
Please add a jsDoc explaining why you do some voodoo here
| /> | ||
| <ResourceContextProvider value={props.reference}> | ||
| <ReferenceArrayInputContextProvider value={controllerProps}> | ||
| <ListContextProvider value={listContext}> |
There was a problem hiding this comment.
I don't get it. What's the use of a ReferenceArrayInputContext if all you need is already in the ListContext?
There was a problem hiding this comment.
I agree it is mostly redundant now but it does provide the warning prop which indicates non "fatal" errors regarding references.
fzaninotto
approved these changes
Feb 24, 2021
This was referenced Mar 9, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.