Fix List view error after delete when using a field with no record test #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Feb 11, 2021
| @@ -41,6 +42,73 @@ describe('useListController', () => { | |||
| debounce: 200, | |||
| }; | |||
|
|
|||
| describe('data', () => { | |||
| it('should be synchronized with ids after delete', async () => { | |||
There was a problem hiding this comment.
this test fails on master
| @@ -181,41 +178,12 @@ const useListController = <RecordType extends Record = Record>( | |||
| } | |||
| ); | |||
|
|
|||
| const data = useSelector( | |||
There was a problem hiding this comment.
Logic moved to a special hook, useGetMainList
djhi
approved these changes
Feb 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty bug that occurs when:
FooField = ({ record }) => <>{record.foo}</>instead ofFooField = ({ record }) => <>{record ? record.foo : null}</>In addition, this bug caused an additional List rerender, so this should also speed up lists a bit.
Note to self: never use both a dataProvider hook and a useSelector in the same function. Because dataProvider hooks rely on useEffect, they will return one tick later than useSelector, resulting in data inconsistencies (in this case: a list of
idscontaining the id of a record already removed from thedatakey).