Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RFR] Add support to select records with Shift + click #5936

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

m4theushw
Copy link
Contributor

@m4theushw m4theushw commented Feb 18, 2021

Related to #5910.

I'm using the last selected item to detect if a single item or multiple items should be toggled. This is similar to Gmail's UX.

Peek 2021-02-14 22-06

@djhi
Copy link
Collaborator

djhi commented Feb 19, 2021

Would you mind adding a screencast to the PR description?

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work btw! Love the test coverage 💪

@fzaninotto fzaninotto merged commit 541fff7 into marmelab:next Feb 19, 2021
@fzaninotto
Copy link
Member

Thanks a lot!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants