Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Form Loose Dirty Fields Values After Cancelling Navigation #6005

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Mar 5, 2021

Fixes #5081

Tried locally with the same setup as in the issue

@djhi djhi added the RFR Ready For Review label Mar 5, 2021
@djhi djhi added this to the 3.13.2 milestone Mar 5, 2021
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@@ -1,17 +1,18 @@
import * as React from 'react';
import { FC, useRef, useCallback, useEffect, useMemo } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter warning

@fzaninotto fzaninotto removed this from the 3.13.2 milestone Mar 7, 2021
@djhi djhi force-pushed the fix-warn-when-unsaved-changes branch from 53c6208 to 569bf17 Compare March 8, 2021 09:30
@fzaninotto
Copy link
Member

Needs rebase again

@djhi djhi force-pushed the fix-warn-when-unsaved-changes branch from 569bf17 to 7ba378c Compare March 8, 2021 16:59
@djhi djhi added this to the 3.13.3 milestone Mar 9, 2021
@fzaninotto fzaninotto merged commit a171deb into master Mar 11, 2021
@fzaninotto fzaninotto deleted the fix-warn-when-unsaved-changes branch March 11, 2021 16:14
@fzaninotto
Copy link
Member

This change likely caused a regression in the handling of default values in Edit forms (see #6198)

@djhi djhi mentioned this pull request Oct 22, 2021
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SimpleForm, TabbedForm] warnWhenUnsavedChanges not working on a real api / data lost on cancel
2 participants