Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change Layout interface to use AppBarProps interface #6035

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Change Layout interface to use AppBarProps interface #6035

merged 1 commit into from
Mar 15, 2021

Conversation

yasharzolmajdi
Copy link
Contributor

Problem

appBar prop on Layout component did not accept AppBarProps interface

Fixes #6019

@yasharzolmajdi yasharzolmajdi force-pushed the fix-layout-appbar-interface branch from 077c2e8 to a769ee8 Compare March 14, 2021 18:22
djhi
djhi requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you fix the linter warning?

@yasharzolmajdi yasharzolmajdi force-pushed the fix-layout-appbar-interface branch from a769ee8 to 91bef26 Compare March 15, 2021 09:33
djhi
djhi approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.13.4 milestone Mar 15, 2021
@djhi djhi merged commit 1beee96 into marmelab:master Mar 15, 2021
This was referenced Mar 15, 2021
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 19, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.

appBar in custom Layout does not accept AppBarProps with typescript strict:true
2 participants
@yasharzolmajdi @djhi