Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TypeScript] Fix SimpleList and other list components can't be used without context #6090

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

fzaninotto
Copy link
Member

Problem

<SimpleList> can be used without a <ListContext>, by passing the required values as props. But TypeScript complains in that case because the component signature doesn't allow passing these props.

Solution

(re-)Add the props in the component signature.

@fzaninotto fzaninotto added the RFR Ready For Review label Mar 29, 2021
@djhi djhi added this to the 3.14 milestone Mar 29, 2021
@djhi djhi merged commit d56cf09 into master Mar 29, 2021
@djhi djhi deleted the fix-list-ts branch March 29, 2021 07:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants