Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix customRoutes aren't used when the resources are empty #6112

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix customRoutes aren't used when the resources are empty #6112

merged 1 commit into from
Apr 2, 2021

Conversation

fzaninotto
Copy link
Member

Closes #6079

@fzaninotto fzaninotto added the RFR Ready For Review label Apr 1, 2021
djhi
djhi approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@djhi djhi added this to the 3.14.2 milestone Apr 2, 2021
@djhi djhi merged commit 87f9b8d into master Apr 2, 2021
@djhi djhi deleted the coreAdminRouter-loading-customRoutes branch April 2, 2021 07:09
@DjebbZ
Copy link
Contributor

DjebbZ commented Apr 7, 2021

Yay!

@fzaninotto fzaninotto mentioned this pull request Apr 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

Lazy initialization of resources stuck in loading if no resources
3 participants
@fzaninotto @DjebbZ @djhi