Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add container prop to AppBar #6178

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Add container prop to AppBar #6178

merged 4 commits into from
Apr 20, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 16, 2021

Implements #6174

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we want to keep the default behavior, I think having to pass false explicitly is not very intuitive. What do you think about adding a stickOnScroll prop which would be false by default? Maybe there is a better name for it though ;)

@fzaninotto
Copy link
Member

Why don't you call this prop container and let users pass a Fragment instead of HideOnScroll?

@WiXSL WiXSL changed the title Add hideOnScroll prop to AppBar Add container prop to AppBar Apr 19, 2021
@WiXSL WiXSL requested a review from djhi April 19, 2021 11:05
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 🎉

Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@fzaninotto fzaninotto merged commit 78f79b3 into marmelab:next Apr 20, 2021
@fzaninotto
Copy link
Member

thanks!

@fzaninotto fzaninotto added this to the 3.15 milestone Apr 20, 2021
@WiXSL WiXSL deleted the disable-hos branch April 20, 2021 16:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants