Support custom DataProvider type with useDataProvider #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Sep 21, 2021
djhi
commented
djhi
commented
Sep 21, 2021
| @@ -201,6 +204,7 @@ export const useQueryWithStore = <State extends ReduxState = ReduxState>( | |||
| queriesThisTick[requestSignature] = new Promise<PartialQueryState>( | |||
| resolve => { | |||
| dataProvider[type](resource, payload, options) | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
There's one thing I wasn't able to address: ensuring that a dataProvider method always returns a Promise. Hence the ignore
fzaninotto
approved these changes
Sep 27, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.