Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix potential data leak for shuffle tasks #2975

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Fix potential data leak for shuffle tasks #2975

merged 3 commits into from
Apr 29, 2022

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

This PR fixes data leak during shuffle tasks.

Related issue number

Fixes #2974

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: storage labels Apr 27, 2022
@hekaisheng hekaisheng added this to the v0.9.0rc3 milestone Apr 27, 2022
@qinxuye qinxuye changed the title Fix potential leak for shuffle tasks Fix potential data leak for shuffle tasks Apr 28, 2022
继盛 and others added 2 commits April 28, 2022 17:18
@hekaisheng hekaisheng marked this pull request as ready for review April 29, 2022 02:56
@hekaisheng hekaisheng requested review from wjsi and qinxuye as code owners April 29, 2022 02:56
qinxuye
qinxuye approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit bb7f906 into mars-project:master Apr 29, 2022
fyrestone added a commit that referenced this pull request Apr 29, 2022
@fyrestone
Revert "Fix potential data leak for shuffle tasks (#2975)"
2f9cebc 
This reverts commit bb7f906.
@fyrestone fyrestone mentioned this pull request Apr 29, 2022
Closed
@hekaisheng hekaisheng mentioned this pull request Apr 29, 2022
Merged
2 tasks
@qinxuye qinxuye deleted the bugfix/leak branch May 6, 2022 03:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
mod: storage type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0rc3
Development

Successfully merging this pull request may close these issues.

[BUG] Shuffle data was not deleted when task finished
3 participants
@hekaisheng @qinxuye @wjsi