Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Limit to push metrics single point in time per flush #2

Merged
merged 9 commits into from
Feb 14, 2023

Conversation

martymarron
Copy link
Owner

Description

This PR adds the restriction to push metrics only at the most recent point in a flush period. This aims to improve the performance of pushing by eliminating redundant metrics to be pushed.
Besides, this PR conducts some code-clean-ups.

@martymarron martymarron mentioned this pull request Feb 13, 2023
@ezh
Copy link

ezh commented Feb 14, 2023

k6 processes its outputs once per second and that is also a default flush period in this extension. The number of k6 builtin metrics is 26 and they are collected at the rate of 50ms. In practice it means that there will be around 1000-1500 samples on average per each flush period in case of raw mapping. If custom metrics are configured, that estimate will have to be adjusted.

https://github.com/my-troubleshooting/sprint-prometheus/tree/main

@martymarron
Copy link
Owner Author

k6 processes its outputs once per second and that is also a default flush period in this extension. The number of k6 builtin metrics is 26 and they are collected at the rate of 50ms. In practice it means that there will be around 1000-1500 samples on average per each flush period in case of raw mapping. If custom metrics are configured, that estimate will have to be adjusted.

https://github.com/my-troubleshooting/sprint-prometheus/tree/main

Good to know. Thanks!

@martymarron martymarron merged commit 4199e89 into main Feb 14, 2023
@martymarron martymarron deleted the feature/push-single-point-per-flush branch February 16, 2023 01:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants