Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add esptool-gui #2203

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add esptool-gui #2203

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 22, 2024

A GUI for ESP8266 flash tool esptool-ck with basic features, geared towards being a production flashing tool.

Log: add software name--esptool-gui
esptool-gui

+target.path = $$PREFIX/bin
+desktop.files = esptool-gui.desktop
+desktop.path = $$PREFIX/share/applications/
+icons.path = $$PREFIX/share/icons/hicolor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon按FAQ下路径调整

A GUI for ESP8266 flash tool esptool-ck with basic features, geared towards being a production flashing tool.

Log: add software name--esptool-gui
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • esptool-gui.desktop文件中,图标路径从esptool-gui更改为esptool-gui-screenshot,需要确认新图标文件是否存在并且路径是否正确。
  • esptool-gui.pro文件中,target.path被设置为$$PREFIX/bin,但是desktop.path被设置为$$PREFIX/share/applications/,这可能不符合Freedesktop标准,应该保持一致性。
  • 新增了icons.pathicons.files,但是没有提供相应的图标文件esptool-gui-screenshot.png,需要确认文件是否已定义。
  • 最后一行添加了一个空行,但是没有必要,应该删除以保持文件整洁。

是否建议立即修改:

  • 确认图标文件的存在性和路径是否正确,以避免安装失败或应用启动时找不到图标。
  • 检查desktop.path的设置是否与其他部分保持一致,以遵循Freedesktop标准。
  • 确保esptool-gui-screenshot.png图标文件已定义,否则安装将失败。
  • 删除最后一行多余的空行,以保持代码整洁。

@kamiyadm kamiyadm merged commit a1d6521 into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants