Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add app routegen #2210

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add app routegen #2210

merged 1 commit into from
May 29, 2024

Conversation

Van020530
Copy link
Contributor

Route Generator (clone frome SourceForge.net)

log: add app

Route Generator (clone frome SourceForge.net)

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix-desktop.patch文件中,缺少了FromDate邮件头信息,这可能会导致邮件发送方无法追踪邮件的来源和发送时间。
  • CMakeLists.txt文件中的install命令新增了PROGRAMS类型,但未提供相应的文件路径或源文件,可能会导致编译错误。
  • 新增的install命令没有指定安装的目标目录,可能会覆盖现有的文件或导致安装位置不正确。
  • 代码中使用了硬编码的文件路径,如../deploy/linux/routegen/usr/share/applications/routegen.desktop,这可能会导致在不同环境下的编译失败。
  • 缺少对新增代码的注释说明,不利于其他开发者理解代码的目的和功能。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm merged commit 37bd29c into martyr-deepin:master May 29, 2024
6 checks passed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants