Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add app AwesomeBump #2216

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

Van020530
Copy link
Contributor

AwesomeBump is a free program written using Qt library designed to generate normal

log: add app

AwesomeBump is a free program written using Qt library designed to generate normal

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix.patch文件中,缺少了+符号,可能导致Patch无法正确应用。
  • Sources/Sources.pro文件中的VPATH += ../sharedINCLUDEPATH += ../shared include utils utils/QtnProperty utils/contextinfo应该在VPATHINCLUDEPATH的定义之后添加+=符号。
  • exists("utils/qtcopydialog/qtcopydialog.pri") {exists("utils/fervor/Fervor.pri") {中的条件判断应该使用if而不是exists,以提高代码的可读性。
  • BINDIR = $$PREFIX/binDATADIR = $$PREFIX/share的定义应该在DEFINES之后添加+=符号。
  • desktop.files = ../AwesomeBump.desktopdesktop.path = $$DATADIR/applications/的定义应该在desktop.files之后添加+=符号。
  • icon.files = resources/icons/AwesomeBump.pngicon.path= $$DATADIR/icons/hicolor/256x256/apps/的定义应该在icon.files之后添加+=符号。
  • config.path = $$BINDIRconfig.files += $$TOP_DIR/Bin/Configs $$TOP_DIR/Bin/Core的定义应该在config.path之后添加+=符号。
  • 最后一行+-- 2.33.1应该添加一个空行,以保持与patches/0001-fix.patch文件中其他行的格式一致。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 2e3fa3c into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants