Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make tag following idempotent #20860

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Make tag following idempotent #20860

merged 1 commit into from
Nov 17, 2022

Conversation

trwnh
Copy link
Member

@trwnh trwnh commented Nov 16, 2022

No description provided.

@ineffyble ineffyble added the bug Something isn't working label Nov 16, 2022
@Gargron Gargron merged commit 7fdeed5 into mastodon:main Nov 17, 2022
@trwnh trwnh deleted the patch-5 branch November 18, 2022 01:20
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Nov 21, 2022
@ClearlyClaire
Copy link
Contributor

FYI this introduced a regression. Sorry I didn't catch that but you should have used find_or_create_by, not first_or_create, which as the name suggests, returns the first record in the table if it isn't empty.

Gargron pushed a commit that referenced this pull request Nov 21, 2022
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Nov 21, 2022
Fixes regression from mastodon#20860
# Conflicts:
#	app/controllers/api/v1/tags_controller.rb
minacle referenced this pull request in uri-life/mastodon Nov 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants