Fix some icon names changed by the Font Awesome 5 #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of "fa-expand" it is "fa-expand-alt", but it seems to be only Pro version. This is used for expand / compress video players. I'm thinking of using "fa-expand" instead of "fa-expand-alt" or changing to something in place.
Before fontawesome-free 5.2.0:
After fontawesome-free 5.2.0 (now): |
|
"fa-expand" and "fa-compress" 's icon is different from the FontAwesome 5 and earlier, but since there is no substitute, I will leave it as it is now. |
mayaeh
changed the title
Gargron
approved these changes
Sep 27, 2018
Gargron
added a commit
that referenced
this pull request
Sep 28, 2018
* Revert "Fix some icon names changed by the Font Awesome 5. (#8796)" This reverts commit 3f9ec3d. * Revert "Migrate to font-awesome 5.0. (#8799)" This reverts commit 8bae145. * Revert "Fix some icons names, unavailable in fontawesome5 (free license). (#8792)" This reverts commit b9c727a. * Revert "Update the icon name changed by the Font Awesome 5. (#8776)" This reverts commit 17af4d2. * Revert "Add bot icon to bot avatars and migrate to newer version of Font Awesome (#8484)" This reverts commit 4b794e1.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #8484 #8776 #8792 .
I am searching instead of "fa-expand" and "fa-compress".
( app/javascript/mastodon/features/video/index.js )