-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add scons icon #2826
feat: add scons icon #2826
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A while ago we've update the way how we design folder icons. Could you please take a look into our updated contribution guidelines and adjust the folder icons to the latest design guidelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make them pixel-perfect so that they fit the grid, this is so that they look sharp on the display
537420f
to
7fa89ad
Compare
Can't say I'm 100% sold on the pixel-perfect direction this project took — at least regarding non-generic types — but I can respect the uniformity y'all are aiming for. The style had to be fairly reworked to fit the constraints, particularly the folders, but they came out well! |
Please reduce the width of the top brick by 2 pixels And it is better to use the usual arrow on the folder icons |
But the arrow on the folder icons is a bit of a complicated solution |
I think I see what you're wanting to do with the top brick suggestion, but it looks really bottom-heavy and weird when reducing it. I'll try an alternative where I widen the space between the upper two bricks instead. EDIT2: Oh actually, the split upper bricks lets me use a traditional arrow again! It's a lil scuffed, but it gets the job done |
464a2ba
to
64e13fb
Compare
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Description
Adds support for SCons, a buildsystem written & configured in Python.
Contribution Guidelines