Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add scons icon #2826

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat: add scons icon #2826

merged 4 commits into from
Jan 23, 2025

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jan 19, 2025

Description

Adds support for SCons, a buildsystem written & configured in Python.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Jan 19, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

PKief
PKief previously requested changes Jan 21, 2025
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A while ago we've update the way how we design folder icons. Could you please take a look into our updated contribution guidelines and adjust the folder icons to the latest design guidelines?

https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#designing-pixel-perfect-icons

Copy link
Contributor

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make them pixel-perfect so that they fit the grid, this is so that they look sharp on the display

@Repiteo Repiteo force-pushed the scons branch 3 times, most recently from 537420f to 7fa89ad Compare January 22, 2025 20:23
@Repiteo
Copy link
Contributor Author

Repiteo commented Jan 22, 2025

Can't say I'm 100% sold on the pixel-perfect direction this project took — at least regarding non-generic types — but I can respect the uniformity y'all are aiming for. The style had to be fairly reworked to fit the constraints, particularly the folders, but they came out well!

@okineadev
Copy link
Contributor

Please reduce the width of the top brick by 2 pixels

And it is better to use the usual arrow on the folder icons

@okineadev
Copy link
Contributor

But the arrow on the folder icons is a bit of a complicated solution

@Repiteo
Copy link
Contributor Author

Repiteo commented Jan 22, 2025

That arrow is as good as it'll get on the folders

I think I see what you're wanting to do with the top brick suggestion, but it looks really bottom-heavy and weird when reducing it. I'll try an alternative where I widen the space between the upper two bricks instead. I don't think either looks better than the old version though EDIT: Ehh, this version is fine. We'll roll with that.

EDIT2: Oh actually, the split upper bricks lets me use a traditional arrow again! It's a lil scuffed, but it gets the job done

@Repiteo Repiteo force-pushed the scons branch 2 times, most recently from 464a2ba to 64e13fb Compare January 22, 2025 21:29
@okineadev okineadev merged commit 668baba into material-extensions:main Jan 23, 2025
4 checks passed
Copy link
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

@Repiteo Repiteo deleted the scons branch January 25, 2025 17:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants