Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update Angular icon with new gradient design #2863

Conversation

JeevanMahesha
Copy link
Contributor

Description

This PR updates the Angular SVG icon to a new version. Replaced old Angular SVG with an updated version.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Jan 30, 2025
Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@JeevanMahesha
Copy link
Contributor Author

@PKief The new Angular icon does not support Material colors. I’d love to get your suggestion on this—should we keep this gradient color exclusively for the Angular icon, or should we adjust it to align with the existing Material color scheme? Let me know your thoughts!

@PKief
Copy link
Member

PKief commented Jan 30, 2025

@JeevanMahesha thank you for the proposal. I can understand the idea and the will to make the icon as close to the original logo as possible. However, we're choosing our colors only from the Material Design color palette. The reason for that is that it gives all icons a very good contrast to other icons and makes the Material Icon Theme to that what it is: a good looking icon set with the touch of Material Design. Once we move away from that icons won't have that good contrast anymore and we're going away from the Material Design.

That's why I'd like to stick with plain Material Design colors and avoid adding gradients to icons if not absolutely necessary.

@JeevanMahesha
Copy link
Contributor Author

Hi @PKief,

Thanks for the detailed feedback! I completely understand the importance of maintaining consistency with the Material Design color palette. Since the gradient doesn’t align with the design principles for this icon set, I’ll go ahead and close this PR.

I appreciate your insights, and I’ll make sure to adhere to the Material Design guidelines in future contributions. Looking forward to collaborating again!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants