Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add folder icons for about shopify and sections #2876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ilan8201
Copy link

@ilan8201 ilan8201 commented Feb 4, 2025

Description

  • Added custom folder icons for shopify, and sections folders.
  • Ensured icons align with the Material Icon Theme design guidelines.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@lucas-labs
Copy link
Member

Hi, thanks for the PR! 😁

There are some visibility issues; especially in light themes:

image

That's why this icon theme never makes use of #ffffff or #000000

You can find more info in the contribution guidelines.

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants