-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Initial Kotlin Multiplatform Support #76
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
* <p>Analogous colors, complementary color, and cache to efficiently, lazily, generate data for | ||
* calculations when needed. | ||
*/ | ||
class TemperatureCache(private val input: Hct) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the file name, there is a missing e
🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this gets considered to merge, I can fix it.
However the filename doesn't really matter in Kotlin, so it's not urgent
IIRC Google doesn't accept pull requests to this repo. |
@mon-jai read description |
@DatL4g if you want them to consider your pull request you need to sign the CLA as per #76 (comment) otherwise I doubt they'll even check the submission |
@danielesegato I did when I opened the PR it just doesn't update the status here, but they know it's signed |
This adds a Kotlin Multiplatform library people asked for months.
Closes #49 and closes #54
May require more improvements, however it's current state is at least the same state as the java (+ further methods e.g. create Theme from Image on Android and JVM).