This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Always commit the model layer value inside a transaction with actions disabled. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns disabled. If the timing's duration was 0 or the animation was instant we were setting the model layer value without disabling actions, which could potentially result in an animation occurring. The proper model value setting logic has now been moved to the top of the animate method and the duplicate logic has been removed.
jverkoey
changed the title
jgunaratne
approved these changes
Nov 21, 2017
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timing's duration was 0 or the animation was instant we were setting the model layer value without disabling actions, which could potentially result in an animation occurring.
The proper model value setting logic has now been moved to the top of the animate method and the duplicate logic has been removed.