Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix MeshSymmetryErrorHandler treating ISYM=-1 as symmetry ON #285

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 15, 2023

7b0c061 fix MeshSymmetryErrorHandler treating ISYM=-1 as symmetry ON
72ac121 PositiveEnergyErrorHandler don't decrease POTIM for static calcs

@janosh janosh added handler Error handler fix Bug fix labels Aug 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (26bf28a) 66.19% compared to head (7b0c061) 66.15%.

❗ Current head 7b0c061 differs from pull request most recent head 72ac121. Consider uploading reports for the commit 72ac121 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   66.19%   66.15%   -0.04%     
==========================================
  Files          51       51              
  Lines        5588     5588              
==========================================
- Hits         3699     3697       -2     
- Misses       1889     1891       +2     
Files Changed Coverage Δ
custodian/vasp/handlers.py 78.68% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit e133fe0 into master Aug 15, 2023
@janosh janosh deleted the fix-MeshSymmetryErrorHandler-isym-check branch August 15, 2023 01:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix Bug fix handler Error handler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants