Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Q-Chem bug fix #293

Merged
merged 17 commits into from
Sep 23, 2023
Merged

Q-Chem bug fix #293

merged 17 commits into from
Sep 23, 2023

Conversation

samblau
Copy link
Contributor

@samblau samblau commented Sep 23, 2023

A bug was introduced during the recent Minor Q-Chem updates PR:

- os.mkdir(local_scratch, exist_ok=True)
+ os.makedirs(local_scratch, exist_ok=True)

I would appreciate it if a new version could please be released after this PR is merged. Thanks!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d78d09) 65.78% compared to head (77d6df1) 65.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   65.78%   65.78%           
=======================================
  Files          51       51           
  Lines        5641     5641           
=======================================
  Hits         3711     3711           
  Misses       1930     1930           
Files Changed Coverage Δ
custodian/qchem/jobs.py 10.27% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit 753e54c into materialsproject:master Sep 23, 2023
@janosh janosh added fix Bug fix qchem Q-Chem general-purpose electronic structure package labels Sep 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fix Bug fix qchem Q-Chem general-purpose electronic structure package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants