Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move tests to their own root-level directory #305

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 15, 2023

Similar to how pymatgen was recently refactored to have all tests in a separate tests/ dir instead of mingled with the code files throughout the package structure (materialsproject/pymatgen@77f89df), this PR re-organizes Custodian in the same way.

@janosh janosh added housekeeping Housekeeping pkg Package tests Test all the things labels Nov 15, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53b031c) 65.56% compared to head (904f52a) 64.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   65.56%   64.35%   -1.21%     
==========================================
  Files          54       56       +2     
  Lines        5546     5664     +118     
==========================================
+ Hits         3636     3645       +9     
- Misses       1910     2019     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit ebbd822 into master Nov 15, 2023
@janosh janosh deleted the move-tests-to-root-dir branch November 15, 2023 00:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
housekeeping Housekeeping pkg Package tests Test all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants