Fix openbabel install to ensure q-chem tests run #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 62.67% 0.00% -62.68%
==========================================
Files 35 35
Lines 3003 3003
==========================================
- Hits 1882 0 -1882
- Misses 1121 3003 +1882 ☔ View full report in Codecov by Sentry. |
|
Yeah, I can help here if you need. |
|
@espottesmith --- thank you! I'll give you write access. Help needed 😅 |
|
Alright. Will try to get to this over the next couple of days. As you can imagine, I won't be writing many PRs next week. |
… Python 3.12 and remove max-parallel: 1
janosh
added
qchem
os.rename(self.input_file, self.input_file + ".last") E FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'mol.qin' -> 'mol.qin.last'
janosh
reviewed
Mar 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #319.
@espottesmith and @samblau: I could use your help to resolve the test errors that have come about over the 7+ months since the q-chem tests have been silently being skipped.