fix #137 and #181 (faulty ROC AUC scores) #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for the PR! I will review and merge soon |
|
As a point of discussion, are there thoughts on using F1 as a replacement for ROCAUC for the leaderboards? Since many of the algorithms only have discretized probability |
|
@hrushikesh-s @computron thoughts on this? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matbench Pull Request Template
Core code/data/docs changes
Brief description of changes
Fix for issues #137 and #181 (Faulty ROC AUC scores, caused by discretized probabilities).
Removal of the
homogenize_clf_arrayfunction indata_ops.pyas it is no longer used.Tests
Tests have been changed accordingly.
Test for
homogenize_clf_arraywas deleted, because the function does not exist anymore.Test for
score_arrayhas been corrected.Closed issues or PRs
Issues: #137, #181