Compositions from weight str #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyuep
reviewed
Nov 18, 2024
| @@ -639,22 +640,52 @@ def from_dict(cls, dct: dict) -> Self: | |||
| return cls(dct) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
I think adding a few init examples for this method would be useful. Similar to the one at the init method of Composition.
…alloys result in different compositons.
|
Thanks. Merged. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often in alloy literature we get composition strings given in weight rather than molar quantities. This PR extends upon the
from_weight_dictmethod to give a more generalfrom_weightsmethod that will take strings as well as CompositionLike