Merge pull request #368 from vbh/fix-dropdown-issue

fix: Dropdown not displayed for tags in edit book screen
mateusz-bak · Nov 23, 2023 · be22060 · be22060
2 parents 29ae950 + f33340a
commit be22060
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 31 deletions.
diff --git a/lib/main.dart b/lib/main.dart
@@ -203,13 +203,6 @@ class _OpenreadsAppState extends State<OpenreadsApp>
         child: MaterialApp(
           title: 'Openreads',
           scaffoldMessengerKey: snackbarKey,
-          builder: (context, child) => MediaQuery(
-            // Temporary fix for https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/463
-            data: MediaQuery.of(context).copyWith(
-              accessibleNavigation: false,
-            ),
-            child: child!,
-          ),
           theme: ThemeData(
             useMaterial3: true,
             colorSchemeSeed: widget.themeState.useMaterialYou

diff --git a/lib/ui/add_book_screen/widgets/tags_text_field.dart b/lib/ui/add_book_screen/widgets/tags_text_field.dart
@@ -86,8 +86,6 @@ class TagsField extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final FocusNode focusNode = FocusNode();
-
     return Padding(
       padding: const EdgeInsets.symmetric(horizontal: 10),
       child: Container(
@@ -101,6 +99,7 @@ class TagsField extends StatelessWidget {
           children: [
             Scrollbar(
                 child: TypeAheadField(
+              ignoreAccessibleNavigation: true,
               itemBuilder: (context, suggestion) {
                 return ListTile(
                   title: Text(suggestion),
@@ -132,7 +131,6 @@ class TagsField extends StatelessWidget {
                 inputFormatters: inputFormatters,
                 textCapitalization: textCapitalization,
                 controller: controller,
-                focusNode: focusNode,
                 minLines: 1,
                 maxLines: maxLines,
                 maxLength: maxLength,

diff --git a/pubspec.lock b/pubspec.lock
@@ -133,10 +133,10 @@ packages:
     dependency: transitive
     description:
       name: collection
-      sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
+      sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
       url: "https://pub.dev"
     source: hosted
-    version: "1.18.0"
+    version: "1.17.2"
   colour:
     dependency: transitive
     description:
@@ -753,10 +753,10 @@ packages:
     dependency: transitive
     description:
       name: meta
-      sha256: a6e590c838b18133bb482a2745ad77c5bb7715fb0451209e1a7567d416678b8e
+      sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
       url: "https://pub.dev"
     source: hosted
-    version: "1.10.0"
+    version: "1.9.1"
   mime:
     dependency: transitive
     description:
@@ -905,10 +905,10 @@ packages:
     dependency: transitive
     description:
       name: petitparser
-      sha256: eeb2d1428ee7f4170e2bd498827296a18d4e7fc462b71727d111c0ac7707cfa6
+      sha256: cb3798bef7fc021ac45b308f4b51208a152792445cce0448c9a4ba5879dd8750
       url: "https://pub.dev"
     source: hosted
-    version: "6.0.1"
+    version: "5.4.0"
   pigment:
     dependency: transitive
     description:
@@ -1041,10 +1041,10 @@ packages:
     dependency: transitive
     description:
       name: shared_preferences_web
-      sha256: "7b15ffb9387ea3e237bb7a66b8a23d2147663d391cafc5c8f37b2e7b4bde5d21"
+      sha256: d762709c2bbe80626ecc819143013cc820fa49ca5e363620ee20a8b15a3e3daf
       url: "https://pub.dev"
     source: hosted
-    version: "2.2.2"
+    version: "2.2.1"
   shared_preferences_windows:
     dependency: transitive
     description:
@@ -1110,18 +1110,18 @@ packages:
     dependency: transitive
     description:
       name: stack_trace
-      sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
+      sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
       url: "https://pub.dev"
     source: hosted
-    version: "1.11.1"
+    version: "1.11.0"
   stream_channel:
     dependency: transitive
     description:
       name: stream_channel
-      sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
+      sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
       url: "https://pub.dev"
     source: hosted
-    version: "2.1.2"
+    version: "2.1.1"
   string_scanner:
     dependency: transitive
     description:
@@ -1150,10 +1150,10 @@ packages:
     dependency: transitive
     description:
       name: test_api
-      sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b"
+      sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.1"
+    version: "0.6.0"
   typed_data:
     dependency: transitive
     description:
@@ -1246,10 +1246,10 @@ packages:
     dependency: transitive
     description:
       name: web
-      sha256: afe077240a270dcfd2aafe77602b4113645af95d0ad31128cc02bce5ac5d5152
+      sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
       url: "https://pub.dev"
     source: hosted
-    version: "0.3.0"
+    version: "0.1.4-beta"
   win32:
     dependency: transitive
     description:
@@ -1278,10 +1278,10 @@ packages:
     dependency: transitive
     description:
       name: xml
-      sha256: af5e77e9b83f2f4adc5d3f0a4ece1c7f45a2467b695c2540381bac793e34e556
+      sha256: "5bc72e1e45e941d825fd7468b9b4cc3b9327942649aeb6fc5cdbf135f0a86e84"
       url: "https://pub.dev"
     source: hosted
-    version: "6.4.2"
+    version: "6.3.0"
   yaml:
     dependency: transitive
     description:
@@ -1291,5 +1291,5 @@ packages:
     source: hosted
     version: "3.1.2"
 sdks:
-  dart: ">=3.2.0 <4.0.0"
-  flutter: ">=3.16.0"
+  dart: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -52,7 +52,7 @@ dependencies:
   shared_storage: ^0.8.0
   shared_preferences: ^2.2.1
   easy_localization: ^3.0.2
-  flutter_typeahead: ^4.6.1
+  flutter_typeahead: ^4.8.0
   flex_color_picker: ^3.2.2
   diacritic: ^0.1.4
   flutter_speed_dial: ^7.0.0