Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE_REQUEST] Filter already set tags from tag list #424

Open
rYR79435 opened this issue Jan 7, 2024 · 9 comments
Open

[FEATURE_REQUEST] Filter already set tags from tag list #424

rYR79435 opened this issue Jan 7, 2024 · 9 comments
Assignees
Labels
accepted enhancement New feature or request good first issue Good for newcomers UX

Comments

@rYR79435
Copy link

rYR79435 commented Jan 7, 2024

Is your feature request related to a problem? Please describe.
When I assign a tag to a book, a list of existing tags is displayed. That list contains tags which have already been assigned to that book. Given that selecting a tag a second time doesn't add it to the book a second time, it is redundant to display it as a choice.

Describe the solution you'd like
When assigning tags to a book, remove already assigned tags from the list of all existing tags.

@rYR79435 rYR79435 added the enhancement New feature or request label Jan 7, 2024
@apobrt apobrt added UX good first issue Good for newcomers labels Jan 7, 2024
@apobrt apobrt self-assigned this Jan 7, 2024
@mateusz-bak
Copy link
Owner

Are you able to handle this @apobrt ?

@th8m0z
Copy link
Contributor

th8m0z commented Jan 11, 2024

I can also handle this

@mateusz-bak
Copy link
Owner

Alright, check with @apobrt then.

@th8m0z
Copy link
Contributor

th8m0z commented Jan 21, 2024

Right now, when testing on the Android emulator, the tags feature seems to be broken.
The addNewTag function throws because the tag is empty.

I'm assuming the expected behaviour would be, that the user can add their own tags?

@th8m0z
Copy link
Contributor

th8m0z commented Jan 22, 2024

Here is a short video displaying the problem:

shortened_tag_bug.1.mp4

@mateusz-bak
Copy link
Owner

There was a new controller that was overwriting original tags controller. I removed it and now adding tags works, you can rebase. #430

@mateusz-bak
Copy link
Owner

@th8m0z how is the work going?

@mateusz-bak mateusz-bak added this to the Release 2.5.0 milestone Feb 13, 2024
@mateusz-bak mateusz-bak assigned th8m0z and unassigned mateusz-bak and apobrt Feb 16, 2024
@th8m0z
Copy link
Contributor

th8m0z commented Feb 23, 2024

Should be done in the next couple of days! @mateusz-bak

@mateusz-bak mateusz-bak removed this from the Release 2.6.0 milestone Mar 13, 2024
@onbreadassist
Copy link

Is the issue fixed ?

Gildas-GH added a commit to Gildas-GH/openreads that referenced this issue Oct 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted enhancement New feature or request good first issue Good for newcomers UX
Projects
None yet
Development

No branches or pull requests

5 participants