Adapt to Coq PR #18591: better refolding of addn induces "simpl never" now respected #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" now respected An equality "2%N = (1 + \rank V)%N" was previously leading to "1%N = (\rank V)%N" after injection but with the PR, it respects "simpl never" and only leads to "1%N = (0 + \rank V)%N". So, we add a rewrite of addSn and add0n to recover the previous behavior. This rewrite is additionally made optional so as to preserve the compatibility. Another simplification, in PFsection13.v, gives "1 + (c - 2)" which now needs an extra add1n.
2 tasks
|
Subsumed by #55 , can be closed |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An equality
2%N = (1 + \rank V)%Nwas previously leading to1%N = (\rank V)%Nafter injection but with Coq PR coq/coq#18591, it respectssimpl neverand only leads to1%N = (0 + \rank V)%N. So, we add a rewrite ofaddSnandadd0nto recover the previous behaviour. This rewrite is additionally made optional so as to preserve the compatibility.Also, a
//=simplification inPFsection13.vgives1 + (c - 2)which now needs an extraadd1n.PS: This is suspectingly backwards-compatible, thus mergeable as soon as now (but I did not test myself).