-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Keyboard Accessibility Pagination Component #963
Conversation
@mr-gabe49 I think you could remove the hovered state implementation (hoverIndex and hover class) and the left, right arrow handling. I've added a comment on the issue: #292 (comment) This gives a general set of guidelines to follow to add accessibility for the pagination component. I believe points 2, 3 and 4 need to be handled. Let me know if the comment answers your questions. |
8623ac7
to
63b2897
Compare
@pavish Regarding point 4 from your 292 Comment, point 3 of Accessibility Matters seems to suggest that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mr-gabe49 The PR looks pretty good.
I have a couple questions. Once resolved, we can merge this PR.
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 95 95
Lines 3463 3463
=======================================
Hits 3230 3230
Misses 233 233
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Related to #292
Technical details
Screenshots
Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin