Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Startup tunes #13

Merged
merged 26 commits into from
Apr 4, 2021
Merged

Startup tunes #13

merged 26 commits into from
Apr 4, 2021

Conversation

saidinesh5
Copy link

@saidinesh5 saidinesh5 commented Mar 15, 2021 •
edited
Loading

Initial support for Startup tunes in Bluejay ESC

Requires: mathiasvr/bluejay#8

@saidinesh5 saidinesh5 mentioned this pull request Mar 15, 2021
Merged
@mathiasvr
Copy link
Owner

Hi, I added a few commits.

I have now measured the beep pulses and made the frequency conversion more accurate, especially for higher frequencies.
I think this somehow messed up the timing of your melody a bit? However, this is now consistent with how it's played on the ESC. Not sure if this is related to your todo about bpm jumping around?

@saidinesh5
bluejay_eeprom_layout: Minor fix to serializing startup melody
4f9e47f
@saidinesh5
rtttl.js: Add error reporting to Rtttl.toBluejayStartupMelody()
229e171
@saidinesh5
Store Rtttl metadata in the first 4 bytes of Bluejay Startup Melody
cdac2e5 
This should make editing bluejay startup tunes a lot less jumpy.
The bluejay startup melody format is now:
[
 [2 bytes of bpm],
 [1 byte of default octave],
 [1 byte of default duration],
 [62 (Temp4, Temp3) values]
]
@saidinesh5
bluejay_defaults: Add defaults for layout version 203
3b11dcf
@mathiasvr
Copy link
Owner

mathiasvr commented Apr 3, 2021 •
edited
Loading

@saidinesh5 I tried to fix the playback by not using imprecise setTimeout.
Can you test if this works for you too startup_tunes_playback.

@saidinesh5 saidinesh5 marked this pull request as ready for review April 3, 2021 23:41
mathiasvr and others added 3 commits April 4, 2021 21:14
@mathiasvr
Update settings
1f53b15
@mathiasvr
Change melody button text
84bd9c6
@saidinesh5
Add support for clearing Settings components internal state
a218ae0 
Using blheli_configurator's state: currentSettingsInstanceId
which gets incremented upon every read
@mathiasvr mathiasvr merged commit cc7f2f5 into mathiasvr:bluejay Apr 4, 2021
@mathiasvr mathiasvr mentioned this pull request Apr 4, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saidinesh5 @mathiasvr