Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update version to beta.3 #974

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Update version to beta.3 #974

merged 3 commits into from
Jul 19, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 19, 2023

This PR includes several changes needed for version 4.0.0-beta.3. These fixes include:

  • Using the correct root path for webpacked node-main.js (for when you use require("mathjax") or import "mathjax" or the same for mathjax-full.
  • Replacing mjs/root.js in the webpacked combined configuration files with a new components/root-pack.mjs that does the same thing as __dirname does in CommonJS webpacking (it replaces it with the directory /). This is not ideal, but it prevents the inclusion of the directory name where the webpacked file was created (e.g., /home/travis/mathjax/MathJax-src/...). The v3 versions had a broken default directory in node as well, so this is no worse than in the past.
  • Fixing some comments (in particular some copyright dates that should not have been ranges).

@dpvc dpvc requested a review from zorkow July 19, 2023 17:28
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm install before merging, so package-lock.json will also be updated to beta.3.

@dpvc
Copy link
Member Author

dpvc commented Jul 19, 2023

Yes, I'm in the process of building the beta.3 font packages, and was going to update the package-lock.json after they are in place, but you beat me to it. Almost there.

@dpvc dpvc merged commit 49db078 into develop Jul 19, 2023
@dpvc dpvc deleted the v4.0-beta.3 branch July 19, 2023 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants