Improves detection for TikTok (#7742)

* Fix user agent test * Improves version detection for TikTok * Improves detection for TikTok
matomo-org · Jul 15, 2024 · a7d3623 · a7d3623
1 parent b543c6b
commit a7d3623
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/Tests/Parser/Client/fixtures/mobile_app.yml b/Tests/Parser/Client/fixtures/mobile_app.yml
@@ -2069,3 +2069,15 @@
     type: mobile app
     name: Zalo
     version: ""
+-
+  user_agent: Mozilla/5.0 (Linux; Android 10; moto g(7) Build/QP6_S30.52-23-13-4; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/108.0.5359.128 Mobile Safari/537.36 musical_ly_2022704050 JsSdk/1.0 NetType/WIFI Channel/googleplay AppName/musical_ly app_version/27.4.5 ByteLocale/en ByteFullLocale/en Region/US Spark/1.2.4-alpha.5 AppVersion/27.4.5 PIA/1.5.10 BytedanceWebview/d8a21c6
+  client:
+    type: mobile app
+    name: TikTok
+    version: 27.4.5
+-
+  user_agent: Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 BytedanceWebview/d8a21c6 trill_34.9.0 JsSdk/2.0 NetType/4G Channel/App Store ByteLocale/en Region/MY FalconTag/31CFA6E0-CAE5-4ECF-A13A-ADFCAFC2428F
+  client:
+    type: mobile app
+    name: TikTok
+    version: 34.9.0
diff --git a/Tests/fixtures/mobile_apps.yml b/Tests/fixtures/mobile_apps.yml
@@ -1168,15 +1168,15 @@
   os_family: Chrome OS
   browser_family: Unknown
 -
-  user_agent: Mozilla/5.0 (Linux; Android 11; 6025H_EEA Build/RP1A.200720.011; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/91.0.4472.120 Mobile Safari/537.36 trill_2022003030 JsSdk/1.0 NetType/WIFI Channel/googleplay AppName/musical_ly app_version/20.
+  user_agent: Mozilla/5.0 (Linux; Android 11; 6025H_EEA Build/RP1A.200720.011; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/91.0.4472.120 Mobile Safari/537.36 trill_2022003030 JsSdk/1.0 NetType/WIFI Channel/googleplay AppName/musical_ly app_version/20.7.5 ByteLocale/en ByteFullLocale/en Region/US
   os:
     name: Android
     version: "11"
     platform: ""
   client:
     type: mobile app
     name: TikTok
-    version: ""
+    version: 20.7.5
   device:
     type: smartphone
     brand: Alcatel

diff --git a/regexes/client/mobile_apps.yml b/regexes/client/mobile_apps.yml
@@ -558,7 +558,10 @@
   version: '$1'
 
 # TikTok (https://apps.apple.com/app/id835599320 | https://play.google.com/store/apps/details?id=com.zhiliaoapp.musically)
-- regex: '(?:TikTok[/ ]|com\.zhiliaoapp\.musically|musical_ly_|AppName/musical_ly app_version/)(\d+\.(?:[\.\d]+))?'
+- regex: 'AppName/musical_ly app_version/(\d+\.(?:[\.\d]+))?'
+  name: 'TikTok'
+  version: '$1'
+- regex: '(?:TikTok[/ ]|com\.zhiliaoapp\.musically|musical_ly_|trill_)(\d+\.(?:[\.\d]+))?'
   name: 'TikTok'
   version: '$1'