Improves version detection for Clecko engine (#7625)

matomo-org · Mar 14, 2024 · cd0bbdb · cd0bbdb
1 parent 0daaf74
commit cd0bbdb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Parser/Client/Browser/Engine/Version.php b/Parser/Client/Browser/Engine/Version.php
@@ -48,8 +48,8 @@ public function parse(): ?array
             return null;
         }
 
-        if ('Gecko' === $this->engine) {
-            $pattern = '~[ ](?:rv[: ]([0-9\.]+)).*gecko/[0-9]{8,10}~i';
+        if ('Gecko' === $this->engine || 'Clecko' === $this->engine) {
+            $pattern = '~[ ](?:rv[: ]([0-9\.]+)).*(?:g|cl)ecko/[0-9]{8,10}~i';
 
             if (\preg_match($pattern, $this->userAgent, $matches)) {
                 return ['version' => \array_pop($matches)];

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -9003,7 +9003,7 @@
     name: Classilla
     version:
     engine: Clecko
-    engine_version:
+    engine_version: 9.3.0
     family: Firefox
 -
   user_agent: w3m/0.52