Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improvements for the OS parser a second level of regular expressions has been added #6793

Merged
merged 15 commits into from
Nov 4, 2021

Conversation

sanchezzzhak
Copy link
Collaborator

Description:

  • moved 102 Apple regular expressions to a regular expression subarray
  • the repetition of constructs when determining the iOS or MAC version has also been reduced

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sanchezzzhak sanchezzzhak deleted the pr_os_3 branch September 3, 2021 16:05
@sanchezzzhak sanchezzzhak restored the pr_os_3 branch September 4, 2021 17:52
@sanchezzzhak sanchezzzhak reopened this Sep 4, 2021
@sanchezzzhak
Copy link
Collaborator Author

I accidentally closed this PR

@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2021

@sanchezzzhak Feel free to merge this one if you think it's fine. The next version after this one being merge will be a major release, so the ports to other languages might notice the change and update their code.

@sanchezzzhak sanchezzzhak merged commit f71d632 into matomo-org:master Nov 4, 2021
@sanchezzzhak sanchezzzhak deleted the pr_os_3 branch November 4, 2021 21:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants