Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improves detection for Android and Oculus Browser #7295

Merged
merged 6 commits into from
Nov 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Tests/Parser/Client/fixtures/browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2138,8 +2138,8 @@
type: browser
name: Oculus Browser
version: "6.0.17.167158974"
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 74.0.3729.182
family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; INTEX AQUA SELFIE Build/NRD90M;) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/77.0.3865.116 Mobile Safari/537.36 JioBrowser/1.4.2
Expand Down Expand Up @@ -7167,3 +7167,16 @@
Sec-CH-UA: '"Chromium";v="106", "Brave Browser";v="106", "Not;A=Brand";v="99"'
Sec-CH-UA-Platform: "Android"
Sec-CH-UA-Mobile: "?1"
-
user_agent: Mozilla/5.0 (X11; Linux x86_64; Quest 2) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/24.3.0.4.63.416895357 SamsungBrowser/4.0 Chrome/106.0.5249.168 VR Safari/537.36
client:
type: browser
name: Oculus Browser
version: 24.3.0.4.63.416895357
engine: Blink
engine_version: 106.0.5249.168
family: Chrome
headers:
Sec-CH-UA: '"Chromium";v="106", "Oculus Browser";v="24", "Not;A=Brand";v="99"'
Sec-CH-UA-Platform: "Linux"
Sec-CH-UA-Mobile: "?0"
16 changes: 16 additions & 0 deletions Tests/Parser/fixtures/oss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3614,3 +3614,19 @@
version: 15.6.1
platform: ""
family: iOS
-
user_agent: Mozilla/5.0 (X11; Linux x86_64; Quest) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/20.0.0.3.8.358844291 SamsungBrowser/4.0 Chrome/98.0.4758.119 VR Safari/537.36
os:
name: Android
short_name: AND
version: ""
platform: x64
family: Android
-
user_agent: Mozilla/5.0 (X11; Linux x86_64; Quest 2) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/22.2.0.3.39.382455783 SamsungBrowser/4.0 Chrome/102.0.5005.148 VR Safari/537.36
os:
name: Android
short_name: AND
version: ""
platform: x64
family: Android
22 changes: 22 additions & 0 deletions Tests/fixtures/clienthints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -793,3 +793,25 @@
model: ""
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (X11; Linux x86_64; Quest 2) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/24.3.0.4.63.416895357 SamsungBrowser/4.0 Chrome/106.0.5249.168 VR Safari/537.36
headers:
Sec-CH-UA: '"Chromium";v="106", "Oculus Browser";v="24", "Not;A=Brand";v="99"'
Sec-CH-UA-Platform: "Linux"
Sec-CH-UA-Mobile: "?0"
os:
name: GNU/Linux
version: ""
platform: x64
client:
type: browser
name: Oculus Browser
version: 24.3.0.4.63.416895357
engine: Blink
engine_version: 106.0.5249.168
device:
type: wearable
brand: Meta
model: Quest 2
os_family: GNU/Linux
browser_family: Chrome
24 changes: 12 additions & 12 deletions Tests/fixtures/wearable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -975,8 +975,8 @@
type: browser
name: Oculus Browser
version: 10.16.0.0.0.296461555
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 91.0.4472.88
device:
type: wearable
brand: Meta
Expand All @@ -993,8 +993,8 @@
type: browser
name: Oculus Browser
version: 13.4.0.3.15.268829550
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 87.0.4280.141
device:
type: wearable
brand: Meta
Expand All @@ -1011,8 +1011,8 @@
type: browser
name: Oculus Browser
version: 13.0.0.2.16.259832224
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 87.0.4280.66
device:
type: wearable
brand: Meta
Expand All @@ -1029,8 +1029,8 @@
type: browser
name: Oculus Browser
version: 8.5.0.4.24.209184609
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 79.0.3945.126
device:
type: wearable
brand: Meta
Expand Down Expand Up @@ -1449,20 +1449,20 @@
-
user_agent: Mozilla/5.0 (X11; Linux x86_64; Quest 2) AppleWebKit/537.36 (KHTML, like Gecko) OculusBrowser/22.2.0.3.39.382455783 SamsungBrowser/4.0 Chrome/102.0.5005.148 VR Safari/537.36
os:
name: GNU/Linux
name: Android
version: ""
platform: x64
client:
type: browser
name: Oculus Browser
version: 22.2.0.3.39.382455783
engine: WebKit
engine_version: "537.36"
engine: Blink
engine_version: 102.0.5005.148
device:
type: wearable
brand: Meta
model: Quest 2
os_family: GNU/Linux
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 8.1; LEO-DLXXE Build/HONORLRA-AL00) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.111 HuaweiBrowser/9.1.1.308 Mobile Safari/537.36
Expand Down
2 changes: 2 additions & 0 deletions regexes/client/browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,8 @@
- regex: 'OculusBrowser(?:/(\d+[\.\d]+))?'
name: 'Oculus Browser'
version: '$1'
engine:
default: 'Blink'

# Jio Browser (https://play.google.com/store/apps/details?id=com.jio.web)
- regex: 'Jio(?:Browser|Pages)(?:/(\d+[\.\d]+))?'
Expand Down
2 changes: 1 addition & 1 deletion regexes/oss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@
name: 'Android'
version: '$1'

- regex: 'BeyondPod|AntennaPod|Podkicker|DoggCatcher|Player FM|okhttp|Podcatcher Deluxe|Sonos/.+\(ACR_'
- regex: 'BeyondPod|AntennaPod|Podkicker|DoggCatcher|Player FM|okhttp|Podcatcher Deluxe|Sonos/.+\(ACR_|Linux x86_64; Quest'
name: 'Android'
version: ''

Expand Down